[
https://issues.apache.org/jira/browse/SOLR-12562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833509#comment-16833509
]
Erick Erickson commented on SOLR-12562:
---------------------------------------
I can take the calls to *materialize()* out and the two test cases pass
(haven't tried a full test suite), but....
That requires that we always get a non-null from
{code}
SchemaField sf = schema.getFieldOrNull(f.name());
{code}
The code explicitly tests for a null return in several cases, so this doesn't
seem safe.
*materialize()* doesn't require a SchemaField at all.
> Remove redundant RealTimeGetCompnent.toSolrDoc and use
> DocStreamer.convertLuceneDocToSolrDoc
> --------------------------------------------------------------------------------------------
>
> Key: SOLR-12562
> URL: https://issues.apache.org/jira/browse/SOLR-12562
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
> Attachments: SOLR-12562.patch
>
>
> This code looks really redundant so we should remove one. The one in
> RealTimeGet is the only used locally so my vote is to remove that one.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
