[ 
https://issues.apache.org/jira/browse/SOLR-12562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833526#comment-16833526
 ] 

David Smiley commented on SOLR-12562:
-------------------------------------

It's not clear how the field might not be in the schema (and tests didn't 
uncover it or you would have said).  Should this happen (and we should add a 
comment that this is really unexpected), I think we could simply call 
f.stringValue() -- this is after all what SchemaField.toObject does by default. 
 This will also work if the field is a number.  I think I'm really leaning on 
consistently converting IndexableField to the opposite of this.

> Remove redundant RealTimeGetCompnent.toSolrDoc and use 
> DocStreamer.convertLuceneDocToSolrDoc
> --------------------------------------------------------------------------------------------
>
>                 Key: SOLR-12562
>                 URL: https://issues.apache.org/jira/browse/SOLR-12562
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Minor
>         Attachments: SOLR-12562.patch
>
>
> This code looks really redundant so we should remove one. The one in 
> RealTimeGet is the only used locally so my vote is to remove that one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to