[
https://issues.apache.org/jira/browse/SOLR-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838794#comment-16838794
]
Christine Poerschke commented on SOLR-12697:
--------------------------------------------
Thanks [~erickerickson] for the ping(s)! I'd seen your earlier comments but
had/have only limited time to continue here.
The just attached patch rebases against latest master, shrinking the patch now
that the SOLR-13049 portion of it is committed.
{quote}Can SOLR-12625 be used in this case or, perhaps, reworked to make it
usable here? ...
{quote}
{quote}... the calls to SolrDocumentFetcher, ...
{quote}
>From a quick look there are several public {{SolrDocumentFetcher}} methods.
>[~slivotov] would you perhaps recall anything about how you chose the method
>to call? I'm not yet familiar with the {{SolrDocumentFetcher}} class.
And two things I noticed and wondered whilst rebasing the patch:
* {{FieldValueFeature.fieldAsSet}} can now be removed since it becomes unused
with the changes here?
* {{docFetcher}} and {{returnFields}} are currently
{{FieldValueFeatureScorer}} members, could they be {{FieldValueFeatureWeight}}
members instead?
> pure DocValues support for FieldValueFeature
> --------------------------------------------
>
> Key: SOLR-12697
> URL: https://issues.apache.org/jira/browse/SOLR-12697
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - LTR
> Reporter: Stanislav Livotov
> Priority: Major
> Attachments: SOLR-12697.patch, SOLR-12697.patch, SOLR-12697.patch,
> SOLR-12697.patch
>
>
> [~slivotov] wrote in SOLR-12688:
> bq. ... FieldValueFeature doesn't support pure DocValues fields (Stored
> false). Please also note that for fields which are both stored and DocValues
> it is working not optimal because it is extracting just one field from the
> stored document. DocValues are obviously faster for such usecases. ...
> (Please see SOLR-12688 description for overall context and analysis results.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
