[
https://issues.apache.org/jira/browse/SOLR-13515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856020#comment-16856020
]
Hoss Man commented on SOLR-13515:
---------------------------------
Sure ... not sure why /SOLR-7090 added {{NoOpRegenerator}} since it was clera
in the comments that {{IdentityRegenerator}} already existed ... looks like
smiley even pointed out hte oddity in a comment that got over looked – but the
nested class is ugly, +1 to removing and sticking with the top level
NoOpRegenerator going forward
(I'm not a huge fan of the name - to me a No-Op regenerator would literally do
nothing, and add nothing to the new cache – but the javadocs are clear enough)
> deprecate-then-remove SolrPluginUtils.IdentityRegenerator
> ---------------------------------------------------------
>
> Key: SOLR-13515
> URL: https://issues.apache.org/jira/browse/SOLR-13515
> Project: Solr
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
>
> {{SolrPluginUtils.IdentityRegenerator}} seems to be identical (no pun
> intended) to {{NoOpRegenerator}}. This ticket proposes to deprecate
> IdentityRegenerator on branch_8x and then remove it on master branch.
> https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.1.1/solr/core/src/java/org/apache/solr/util/SolrPluginUtils.java#L977-L997
> https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.1.1/solr/core/src/java/org/apache/solr/search/NoOpRegenerator.java
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
