[ 
https://issues.apache.org/jira/browse/SOLR-13515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856978#comment-16856978
 ] 

Christine Poerschke commented on SOLR-13515:
--------------------------------------------

bq. ... not sure why /SOLR-7090 added {{NoOpRegenerator}} ...

{{NoOpRegenerator}} was added in SOLR-5182 actually.

bq. ... looks like smiley even pointed out ...

Thanks for pointing out that [~dsmiley] pointed out in SOLR-7090 the same thing 
I independently uncovered here, I missed that since did not scan past the first 
comment on that issue.

Will proceed with change here early next week hopefully assuming no objections.

> deprecate-then-remove SolrPluginUtils.IdentityRegenerator
> ---------------------------------------------------------
>
>                 Key: SOLR-13515
>                 URL: https://issues.apache.org/jira/browse/SOLR-13515
>             Project: Solr
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>
> {{SolrPluginUtils.IdentityRegenerator}} seems to be identical (no pun 
> intended) to {{NoOpRegenerator}}. This ticket proposes to deprecate 
> IdentityRegenerator on branch_8x and then remove it on master branch.
> https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.1.1/solr/core/src/java/org/apache/solr/util/SolrPluginUtils.java#L977-L997
> https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.1.1/solr/core/src/java/org/apache/solr/search/NoOpRegenerator.java



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to