[
https://issues.apache.org/jira/browse/LUCENE-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872781#comment-16872781
]
Robert Muir commented on LUCENE-8871:
-------------------------------------
+1 from me. I looked thru the PR, it is just as described. Because the code
moved from src/tools it suddenly requires higher standard for the build, and
now tests are executed in every build. I think this is exactly what we want.
Thanks Mike!
> Move Kuromoji DictionaryBuilder tool from src/tools to src/
> ------------------------------------------------------------
>
> Key: LUCENE-8871
> URL: https://issues.apache.org/jira/browse/LUCENE-8871
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Mike Sokolov
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently tests in tools directories are not run as part of the normal
> testing done by {{ant test}} - you have to explicitly run {{test-tools}},
> which it seems people don't do (and it might not survivie translation to
> gradle, who knows), so [~rcmuir] suggested we just move the tools into the
> main source tree (under src/java and src/test)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
