[
https://issues.apache.org/jira/browse/LUCENE-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16874008#comment-16874008
]
Mike Sokolov commented on LUCENE-8871:
--------------------------------------
I see what you did there! Thank you for fixing. I have to say I'm
really confused why this failed now, yet I am pretty sure I ran
precommit earlier. I may have been distracted and forgot, but I
thought I had done it. In principle the visibility changes seem OK to
me, but I wonder why they were needed. I would have thought these
classes were only referenced from their own package? I'm not seeing
the whole picture - maybe some crosstalk between o.a.l.a.ja.dict and
o.a.l.a.ja.util?
> Move Kuromoji DictionaryBuilder tool from src/tools to src/
> ------------------------------------------------------------
>
> Key: LUCENE-8871
> URL: https://issues.apache.org/jira/browse/LUCENE-8871
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Mike Sokolov
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently tests in tools directories are not run as part of the normal
> testing done by {{ant test}} - you have to explicitly run {{test-tools}},
> which it seems people don't do (and it might not survivie translation to
> gradle, who knows), so [~rcmuir] suggested we just move the tools into the
> main source tree (under src/java and src/test)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
