[
https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876335#comment-16876335
]
Atri Sharma commented on LUCENE-8857:
-------------------------------------
[~jpountz] I investigated this and it turned out to be a test limitation
(testGrouping assumed that TopDocs.merge was setting the shard indices). It
took a while to reproduce since it was the random test which was failing
(thanks for providing the seed!) I have fixed the test and ran ant test a
couple of times – it came in clean:
Can we push this in now?
{code:java}
[junit4:tophints] 49.54s |
org.apache.lucene.search.suggest.document.TestSuggestField
[junit4:tophints] 21.55s |
org.apache.lucene.search.suggest.analyzing.FuzzySuggesterTest
[junit4:tophints] 21.51s |
org.apache.lucene.search.suggest.DocumentDictionaryTest
[junit4:tophints] 15.45s | org.apache.lucene.search.spell.TestSpellChecker
-check-totals:
common.test:
-check-totals:
test:
BUILD SUCCESSFUL
Total time: 49 minutes 49 seconds
f01898a404cf:lucene atris$ {code}
[~munendrasn] I am not too aware of Solr's internals, but looking at the error
you pointed to, looks like that the test is not setting shard indices or hit
indices. This points to an assumption in the test – that TopDocs.merge is
setting the shard indices. Can you check
{code:java}
search/grouping/distributed/responseprocessor/TopGroupsShardResponseProcessor.java{code}
where the TopDocs.merge call is done? We can set shard indices for all TopHits
based on the QueryCommandResult they come from.
> Refactor TopDocs#Merge To Take In Custom Tie Breakers
> -----------------------------------------------------
>
> Key: LUCENE-8857
> URL: https://issues.apache.org/jira/browse/LUCENE-8857
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Atri Sharma
> Priority: Major
> Fix For: master (9.0)
>
> Attachments: LUCENE-8857.patch, LUCENE-8857.patch, LUCENE-8857.patch,
> LUCENE-8857.patch, LUCENE-8857.patch
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> In LUCENE-8829, the idea of having lambdas passed in to the API to allow
> finer control over the process was discussed.
> This JIRA tracks adding a parameter to the API which allows passing in
> lambdas to define custom tie breakers, thus allowing users to do custom
> algorithms when required.
> CC: [~jpountz] [~simonw]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
