[
https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876759#comment-16876759
]
Atri Sharma commented on LUCENE-8857:
-------------------------------------
[~jpountz] I have pushed the latest iteration to the new PR. It passes ant test:
{code:java}
[junit4:tophints] 59.58s |
org.apache.lucene.search.suggest.document.TestSuggestField
[junit4:tophints] 17.10s |
org.apache.lucene.search.suggest.DocumentDictionaryTest
[junit4:tophints] 14.56s |
org.apache.lucene.search.suggest.fst.FSTCompletionTest
[junit4:tophints] 14.21s |
org.apache.lucene.search.suggest.analyzing.FuzzySuggesterTest
-check-totals:
common.test:
-check-totals:
test:
BUILD SUCCESSFUL
Total time: 74 minutes 29 seconds
f01898a404cf:lucene atris$
{code}
It also passes the offending Solr test:
ant test -Dtestcase=TestDistributedGrouping -Dtests.method=test
-Dtests.seed=B5D95BEAE23E9468 -Dtests.slow=true -Dtests.badapples=true
-Dtests.locale=nl-AW -Dtests.timezone=Asia/Jayapura -Dtests.asserts=true
-Dtests.file.encoding=UTF-8
{code:java}
27429 INFO (closeThreadPool-74-thread-4) [ ] o.e.j.s.AbstractConnector
Stopped ServerConnector@3e6caf50{HTTP/1.1,[http/1.1, h2c]}{127.0.0.1:0}
27430 INFO (closeThreadPool-74-thread-4) [ ] o.e.j.s.h.ContextHandler
Stopped o.e.j.s.ServletContextHandler@169e0265{/,null,UNAVAILABLE}
27430 INFO (closeThreadPool-74-thread-4) [ ] o.e.j.s.session node0 Stopped
scavenging
27431 INFO (closeThreadPool-74-thread-1) [ ] o.e.j.s.AbstractConnector
Stopped ServerConnector@1be02e89{HTTP/1.1,[http/1.1, h2c]}{127.0.0.1:0}
27431 INFO (closeThreadPool-74-thread-1) [ ] o.e.j.s.h.ContextHandler
Stopped o.e.j.s.ServletContextHandler@6b6f3dda{/,null,UNAVAILABLE}
27432 INFO (closeThreadPool-74-thread-1) [ ] o.e.j.s.session node0 Stopped
scavenging
27432 INFO (closeThreadPool-74-thread-5) [ ] o.e.j.s.AbstractConnector
Stopped ServerConnector@4052b482{HTTP/1.1,[http/1.1, h2c]}{127.0.0.1:0}
27432 INFO (closeThreadPool-74-thread-5) [ ] o.e.j.s.h.ContextHandler
Stopped o.e.j.s.ServletContextHandler@7063254f{/,null,UNAVAILABLE}
27432 INFO (closeThreadPool-74-thread-5) [ ] o.e.j.s.session node0 Stopped
scavenging
27436 INFO (SUITE-TestDistributedGrouping-seed#[C817F4DEFFC8F2A7]-worker) [
] o.a.s.SolrTestCaseJ4 -------------------------------------------------------
Done waiting for tracked resources to be released{code}
> Refactor TopDocs#Merge To Take In Custom Tie Breakers
> -----------------------------------------------------
>
> Key: LUCENE-8857
> URL: https://issues.apache.org/jira/browse/LUCENE-8857
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Atri Sharma
> Priority: Major
> Fix For: master (9.0)
>
> Attachments: LUCENE-8857-compile-fix.patch, LUCENE-8857.patch,
> LUCENE-8857.patch, LUCENE-8857.patch, LUCENE-8857.patch, LUCENE-8857.patch
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> In LUCENE-8829, the idea of having lambdas passed in to the API to allow
> finer control over the process was discussed.
> This JIRA tracks adding a parameter to the API which allows passing in
> lambdas to define custom tie breakers, thus allowing users to do custom
> algorithms when required.
> CC: [~jpountz] [~simonw]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
