iverase commented on a change in pull request #726: LUCENE-8632: New XYShape
Field and Queries for indexing and searching general cartesian geometries
URL: https://github.com/apache/lucene-solr/pull/726#discussion_r299802905
##########
File path: lucene/sandbox/src/java/org/apache/lucene/geo/Tessellator.java
##########
@@ -167,7 +228,10 @@ private static final Node eliminateHoles(final Polygon
polygon, Node outerNode)
}
nodeIndex += holes[i].numPoints();
}
+ return eliminateHoles(holeList, holeListPolygons, outerNode);
+ }
+ private static final Node eliminateHoles(List<Node> holeList, final Map
holeListPolygons, Node outerNode) {
Review comment:
Map should have generics?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
