iverase commented on a change in pull request #726: LUCENE-8632: New XYShape Field and Queries for indexing and searching general cartesian geometries URL: https://github.com/apache/lucene-solr/pull/726#discussion_r299915146
########## File path: lucene/sandbox/src/java/org/apache/lucene/document/ShapeField.java ########## @@ -0,0 +1,303 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.document; + +import org.apache.lucene.geo.GeoUtils; +import org.apache.lucene.geo.Line; +import org.apache.lucene.geo.Polygon; +import org.apache.lucene.geo.Tessellator; +import org.apache.lucene.util.BytesRef; +import org.apache.lucene.util.NumericUtils; + +/** + * A base shape utility class used for both LatLon (spherical) and XY (cartesian) shape fields. + * <p> + * {@link Polygon}'s and {@link Line}'s are decomposed into a triangular mesh using the {@link Tessellator} utility class. + * Each {@link Triangle} is encoded by this base class and indexed as a seven dimension multi-value field. + * <p> + * Finding all shapes that intersect a range (e.g., bounding box), or target shape, at search time is efficient. + * <p> + * This class defines the static methods for encoding the three vertices of a tessellated triangles as a seven dimension point. + * The coordinates are converted from double precision values into 32 bit integers so they are sortable at index time. + * <p> + * + * @lucene.experimental + */ +public abstract class ShapeField { + /** vertex coordinates are encoded as 4 byte integers */ Review comment: This class is abstract but not implemented by any other. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
