atris commented on issue #769: LUCENE-8905: Better Error Handling For Illegal 
Arguments
URL: https://github.com/apache/lucene-solr/pull/769#issuecomment-510398140
 
 
   
   > For instance I suspect that most of those are due to the call to `return 
TopFieldCollector.create(rewrittenSort, cappedNumHits, after, 
TOTAL_HITS_THRESHOLD);` in IndexSearcher, which we'd just need to replace with 
`return TopFieldCollector.create(rewrittenSort, cappedNumHits, after, 
Math.max(cappedNumHits, TOTAL_HITS_THRESHOLD));`?
   
   -Dtests.timezone=Etc/GMT+5 -Dtests.asserts=true -Dtests.file.encoding=UTF-8
      [junit4] ERROR   0.01s J0 | TestIndexSearcher.testHugeN <<<
   
    Throwable #1: java.lang.IllegalArgumentException: Illegal arguments when 
requesting top docs
      [junit4]    >     at 
__randomizedtesting.SeedInfo.seed([5E8112825AFE9F23:231370EC0B1BDF30]:0)
      [junit4]    >     at 
org.apache.lucene.search.TopDocsCollector.topDocs(TopDocsCollector.java:141)
      [junit4]    >     at 
org.apache.lucene.search.TopDocsCollector.topDocs(TopDocsCollector.java:96)
      [junit4]    >     at 
org.apache.lucene.search.IndexSearcher$2.reduce(IndexSearcher.java:480)
      [junit4]    >     at 
org.apache.lucene.search.IndexSearcher$2.reduce(IndexSearcher.java:468)
      [junit4]    >     at 
org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:636)
      [junit4]    >     at 
org.apache.lucene.search.IndexSearcher.searchAfter(IndexSearcher.java:487)
      [junit4]    >     at 
org.apache.lucene.search.TestIndexSearcher.testHugeN(TestIndexSearcher.java:104)
      [junit4]    >     at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      [junit4]    >     at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      [junit4]    >     at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to