cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second
grouping step if group.limit is 1 (aka Las Vegas Patch)
URL: https://github.com/apache/lucene-solr/pull/300#discussion_r303101673
##########
File path:
solr/core/src/java/org/apache/solr/search/grouping/distributed/shardresultserializer/SearchGroupsResultTransformer.java
##########
@@ -34,17 +41,37 @@
/**
* Implementation for transforming {@link SearchGroup} into a {@link
NamedList} structure and visa versa.
*/
-public class SearchGroupsResultTransformer implements
ShardResultTransformer<List<Command>, Map<String,
SearchGroupsFieldCommandResult>> {
+public abstract class SearchGroupsResultTransformer implements
ShardResultTransformer<List<Command>, Map<String,
SearchGroupsFieldCommandResult>> {
Review comment:
Thanks @diegoceccarelli for the SOLR-13585 review! I'll aim to commit it on
Monday then. Rebasing on top of that will also pick up other grouping related
changes that happened recently-ish i.e. they will be good to have as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
