cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second 
grouping step if group.limit is 1 (aka Las Vegas Patch)
URL: https://github.com/apache/lucene-solr/pull/300#discussion_r304929695
 
 

 ##########
 File path: 
solr/core/src/java/org/apache/solr/search/grouping/distributed/shardresultserializer/SearchGroupsResultTransformer.java
 ##########
 @@ -34,17 +41,37 @@
 /**
  * Implementation for transforming {@link SearchGroup} into a {@link 
NamedList} structure and visa versa.
  */
-public class SearchGroupsResultTransformer implements 
ShardResultTransformer<List<Command>, Map<String, 
SearchGroupsFieldCommandResult>> {
+public abstract class SearchGroupsResultTransformer implements 
ShardResultTransformer<List<Command>, Map<String, 
SearchGroupsFieldCommandResult>> {
 
 Review comment:
   SOLR-13585 is now committed to master and branch_8x branches; apologies for 
the delay, the 8.2.0 release process was already underway and I was waiting for 
the 8.3.0 section to be ready in the solr/CHANGES.txt file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to