[
https://issues.apache.org/jira/browse/SOLR-13643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894318#comment-16894318
]
Neal Sidhwaney commented on SOLR-13643:
---------------------------------------
The new names and making them private sounds good to me.
Re: the type of _analyticsRequestManager. I'll admit I didn't have time to
look back at the entire history of the code, but my best guess was that the
methods in AnalyticsRequestComponent can't store state im
AnalyticsRequestComponent to be referred to between calls to init/process,
which is why they store it in ResponseBuilder. It may be somethin to abstrct
away through an object that is passed to each call to init/prepare in the
future) . But if ResponseBuilder knew about the types inside the analytics
component, it would create a dependency from the core package on contrib.
Thank you Munendra.
Neal
> ResponseBuilder should provide accessors/setters for analytics response
> handling
> --------------------------------------------------------------------------------
>
> Key: SOLR-13643
> URL: https://issues.apache.org/jira/browse/SOLR-13643
> Project: Solr
> Issue Type: Task
> Components: Response Writers
> Affects Versions: 8.1.1
> Reporter: Neal Sidhwaney
> Assignee: Munendra S N
> Priority: Trivial
> Attachments:
> SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch,
> SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch, SOLR-13643.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Right now inside o.a.s.h.c.AnalyticsComponent.java, fields inside
> ResponseBuilder are accessed directly. Since they're in the same package,
> this is OK at compile tie. But when the Solr core and Analytics jars are
> loaded at runtime by Solr, they are done by different classloaders, which
> causes an IllegalAccessError during request handling. There must be soething
> different about y setup which is why I am running into this, but it seems
> like a good idea to abstract away the fields behinds setters/getters anyway.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
