[ https://issues.apache.org/jira/browse/SOLR-13643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894532#comment-16894532 ]
Lucene/Solr QA commented on SOLR-13643: --------------------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 34s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green} 1m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green} 1m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green} 1m 35s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 3s{color} | {color:green} analytics in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 32m 42s{color} | {color:green} core in the patch passed. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 42m 58s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | SOLR-13643 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12976037/SOLR-13643.patch | | Optional Tests | compile javac unit ratsources checkforbiddenapis validatesourcepatterns | | uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | ant | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh | | git revision | master / 4050ddc59b | | ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 | | Default Java | LTS | | Test Results | https://builds.apache.org/job/PreCommit-SOLR-Build/510/testReport/ | | modules | C: solr solr/contrib/analytics solr/core U: solr | | Console output | https://builds.apache.org/job/PreCommit-SOLR-Build/510/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > ResponseBuilder should provide accessors/setters for analytics response > handling > -------------------------------------------------------------------------------- > > Key: SOLR-13643 > URL: https://issues.apache.org/jira/browse/SOLR-13643 > Project: Solr > Issue Type: Task > Components: Response Writers > Affects Versions: 8.1.1 > Reporter: Neal Sidhwaney > Assignee: Munendra S N > Priority: Trivial > Attachments: > SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch, > SOLR-13643-Create-accessors-setters-in-ResponseBuild.patch, SOLR-13643.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Right now inside o.a.s.h.c.AnalyticsComponent.java, fields inside > ResponseBuilder are accessed directly. Since they're in the same package, > this is OK at compile tie. But when the Solr core and Analytics jars are > loaded at runtime by Solr, they are done by different classloaders, which > causes an IllegalAccessError during request handling. There must be soething > different about y setup which is why I am running into this, but it seems > like a good idea to abstract away the fields behinds setters/getters anyway. > > -- This message was sent by Atlassian JIRA (v7.6.14#76016) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org