sigram commented on a change in pull request #825: SOLR-13677 All Metrics
Gauges should be unregistered by the objects that registered them
URL: https://github.com/apache/lucene-solr/pull/825#discussion_r312872979
##########
File path: solr/core/src/java/org/apache/solr/search/LFUCache.java
##########
@@ -254,8 +255,13 @@ private static String calcHitRatio(long lookups, long
hits) {
return "0." + hundredths;
}
+
+ private MetricsInfo metricsInfo;
+
@Override
public void initializeMetrics(SolrMetricManager manager, String
registryName, String tag, String scope) {
+ metricsInfo = new MetricsInfo(manager, registryName,
getUniqueMetricTag(tag));
+ tag = metricsInfo.getTag();
Review comment:
Not needed, since the call below uses metricsInfo.getTag().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
