sigram commented on a change in pull request #825: SOLR-13677 All Metrics
Gauges should be unregistered by the objects that registered them
URL: https://github.com/apache/lucene-solr/pull/825#discussion_r312818632
##########
File path: solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java
##########
@@ -145,8 +145,14 @@ public void init(NamedList args) {
}
+ protected MetricsInfo metricsInfo;
+
+
@Override
public void initializeMetrics(SolrMetricManager manager, String
registryName, String tag, final String scope) {
+ metricsInfo = new MetricsInfo(manager, registryName,
getUniqueMetricTag(tag)) ;
+ tag = metricsInfo.getTag();
+ getUniqueMetricTag(tag);
Review comment:
Method call with no effect?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
