tflobbe commented on a change in pull request #817: SOLR-13655:Upgrade
Collections.unModifiableSet to Set.of and Set.copyOf
URL: https://github.com/apache/lucene-solr/pull/817#discussion_r316982527
##########
File path: solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java
##########
@@ -272,7 +271,7 @@ public boolean canBeRemoved() {
}
- public static final Set<String> KNOWN_CLUSTER_PROPS = unmodifiableSet(new
HashSet<>(asList(
+ public static final Set<String> KNOWN_CLUSTER_PROPS = Set.copyOf(asList(
Review comment:
why not `Set.of`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
