tflobbe commented on a change in pull request #817: SOLR-13655:Upgrade
Collections.unModifiableSet to Set.of and Set.copyOf
URL: https://github.com/apache/lucene-solr/pull/817#discussion_r316983619
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/DelegationTokenHttpSolrClient.java
##########
@@ -99,7 +99,7 @@ protected HttpRequestBase createMethod(final SolrRequest
request, String collect
@Override
public void setQueryParams(Set<String> queryParams) {
queryParams = queryParams == null ?
- Collections.unmodifiableSet(new
HashSet<String>(Arrays.asList(DELEGATION_TOKEN_PARAM))): queryParams;
+ Set.copyOf(Arrays.asList(DELEGATION_TOKEN_PARAM)): queryParams;
Review comment:
`Set.of`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
