atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early Termination In Parallel Search URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-524335774 > Sorry I don't follow. The logic for early termination should be the same in `TopFieldCollector` than the one you put in `SharedHitCountFieldCollector`. Yes, that is correct, but adding it to `TopFieldCollector` would mean that it is a part of `SimpleFieldCollector` and `PagingFieldCollector` code paths as well, and I was conservatively not modifying existing functionality (not atleast until we discussed it in the community). > I also don't understand why you decrement the global total hits counter ? Shouldn't it be equivalent to a shared totalHits in the current impl ? Are you referring to the case when the global hits counter is decremented right when we cross the threshold?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
