atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early Termination In Parallel Search URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-525754830 @jimczi Thanks, I updated per your comments. Please let me know if it seems fine. RE: benchmarks, the numbers I posted earlier were on wikimedium10k. I did a run of wikimedium2m and saw the following: TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff HighTermMonthSort 256.49 (14.6%) 240.49 (13.0%) -6.2% ( -29% - 24%) HighTermDayOfYearSort 140.97 (8.4%) 137.26 (8.6%) -2.6% ( -18% - 15%) Fuzzy2 67.54 (20.4%) 65.90 (19.3%) -2.4% ( -34% - 46%) MedTerm 1430.97 (4.8%) 1404.31 (4.2%) -1.9% ( -10% - 7%) AndHighLow 859.98 (5.2%) 847.48 (4.1%) -1.5% ( -10% - 8%) Respell 111.18 (2.4%) 110.17 (2.5%) -0.9% ( -5% - 4%) Prefix3 278.56 (3.3%) 276.16 (2.5%) -0.9% ( -6% - 5%) LowTerm 1635.42 (5.3%) 1628.34 (3.2%) -0.4% ( -8% - 8%) Fuzzy1 65.18 (11.5%) 64.94 (12.6%) -0.4% ( -21% - 26%) Wildcard 184.51 (3.0%) 183.97 (3.3%) -0.3% ( -6% - 6%) HighPhrase 150.25 (2.8%) 149.83 (2.9%) -0.3% ( -5% - 5%) PKLookup 124.37 (3.6%) 124.04 (3.4%) -0.3% ( -7% - 7%) HighTerm 991.92 (4.7%) 990.52 (4.7%) -0.1% ( -9% - 9%) BrowseDayOfYearTaxoFacets 9293.85 (4.9%) 9291.07 (5.4%) -0.0% ( -9% - 10%) LowSloppyPhrase 143.41 (1.9%) 143.38 (2.1%) -0.0% ( -3% - 4%) BrowseMonthSSDVFacets 43.43 (0.9%) 43.42 (1.0%) -0.0% ( -1% - 1%) MedPhrase 93.36 (1.5%) 93.41 (2.2%) 0.0% ( -3% - 3%) HighSloppyPhrase 43.97 (2.4%) 43.99 (2.4%) 0.1% ( -4% - 5%) MedSloppyPhrase 108.07 (2.1%) 108.15 (1.8%) 0.1% ( -3% - 4%) BrowseDayOfYearSSDVFacets 38.85 (0.6%) 38.88 (0.5%) 0.1% ( -1% - 1%) LowPhrase 181.55 (1.8%) 181.82 (1.6%) 0.1% ( -3% - 3%) MedSpanNear 66.17 (4.4%) 66.28 (3.0%) 0.2% ( -7% - 8%) HighSpanNear 110.26 (3.3%) 110.57 (2.6%) 0.3% ( -5% - 6%) LowSpanNear 84.69 (1.9%) 84.94 (2.0%) 0.3% ( -3% - 4%) HighIntervalsOrdered 47.21 (0.9%) 47.37 (1.5%) 0.3% ( -1% - 2%) AndHighHigh 118.46 (4.3%) 119.01 (3.9%) 0.5% ( -7% - 8%) AndHighMed 187.97 (3.8%) 188.85 (3.4%) 0.5% ( -6% - 8%) OrHighHigh 79.07 (3.0%) 79.45 (2.5%) 0.5% ( -4% - 6%) IntNRQ 238.67 (4.3%) 239.97 (3.5%) 0.5% ( -6% - 8%) OrHighLow 429.26 (4.4%) 432.55 (3.3%) 0.8% ( -6% - 8%) OrHighMed 170.16 (3.0%) 171.65 (2.8%) 0.9% ( -4% - 6%) BrowseDateTaxoFacets 11.28 (2.6%) 11.39 (3.7%) 0.9% ( -5% - 7%) BrowseMonthTaxoFacets 9470.41 (6.2%) 9584.95 (4.7%) 1.2% ( -9% - 12%)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
