thomaswoeckinger commented on a change in pull request #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#discussion_r319738979
##########
File path: solr/core/src/java/org/apache/solr/handler/loader/XMLLoader.java
##########
@@ -429,7 +434,18 @@ public SolrInputDocument readDoc(XMLStreamReader parser)
throws XMLStreamExcepti
break;
} else if ("field".equals(parser.getLocalName())) {
// should I warn in some text has been found too
- Object v = isNull ? null : text.toString();
+ Object v;
Review comment:
The interesting part is below, just using old style if then else for better
readability, and yes it's required for binary support when using XML. The
corresponding AtomicUpdateTest will fail otherwise.
An additional note: there is no other binary XML test in the whole suite,
this was the reason that binary XML support was not working at least since
6.6.2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
