thomaswoeckinger commented on a change in pull request #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#discussion_r320267334
##########
File path: solr/core/src/java/org/apache/solr/handler/loader/XMLLoader.java
##########
@@ -429,7 +434,18 @@ public SolrInputDocument readDoc(XMLStreamReader parser)
throws XMLStreamExcepti
break;
} else if ("field".equals(parser.getLocalName())) {
// should I warn in some text has been found too
- Object v = isNull ? null : text.toString();
+ Object v;
Review comment:
> So, just to make sure I understand: what is "binary XML" here? Is this XML
where some node in the XML doc has binary content? Is this normal XML where the
whole XML doc/string has been encoded using some binary format for compression
or quicker transmission?
>
There are several ways to transport binary data over XML, i used the one
which seems to be the clearest most readable one from my point of view, which
is also the proposed way on xml.com:
https://www.xml.com/pub/a/98/07/binary/binary.html
> > this was the reason binary XML support was not working at least since
6.6.2
>
> Interesting. Is this something that Solr claimed to support or had support
for at some point? Or this is a new ability that Solr has never had that you're
adding here?
Some versions before 6.6.2 EmbeddedSolrServer used XMLCodec as default
codec. When people start using it more in there test cases there where some
issues regarding enums, etc.. so the codec was switched to JavaBinCodec which
was the default when using SolrJ anyway. So this feature was not needed any
more, anyway as far as i know all the other codecs are supporting transport of
binary data. So if anyone want to use XML when talking to Solr he can send
binaries now, it is also required for the new tests, the would fail otherwise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
