gus-asf commented on a change in pull request #838: SOLR-13705 Double-checked
locking bug is fixed.
URL: https://github.com/apache/lucene-solr/pull/838#discussion_r321050532
##########
File path:
solr/core/src/java/org/apache/solr/handler/admin/SecurityConfHandler.java
##########
@@ -303,11 +306,11 @@ public String toString() {
}
});
- this.apis = ImmutableList.copyOf(apis);
+ syncedApis = ImmutableList.copyOf(syncedApis);
}
}
}
- return this.apis;
+ return syncedApis;
Review comment:
And here we return the mutable collection???
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
