gus-asf commented on a change in pull request #838: SOLR-13705 Double-checked
locking bug is fixed.
URL: https://github.com/apache/lucene-solr/pull/838#discussion_r321052124
##########
File path:
solr/core/src/java/org/apache/solr/handler/admin/SecurityConfHandler.java
##########
@@ -303,11 +306,11 @@ public String toString() {
}
});
- this.apis = ImmutableList.copyOf(apis);
+ syncedApis = ImmutableList.copyOf(syncedApis);
Review comment:
actually, I guess in the code as it stands the prior assigment will actually
allow us to return the prior work, but we haven't assigned the immutable copy
anywhere so the next time this is called the return value will be mutable....
If the prior line is removed *then* we repeat the work unless this is changed
too...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
