Final note before I turn in. “ant -Dtestcase=TestKoreanTokenizer” fails OOB on the gradle_8 branch with:
java.lang.RuntimeException: Cannot find userdict.txt in test classpath! I see on master that that file is copied into lucene/build/analysis/nori/classes/test/org/apache/lucene/analysis/ko/userdict.txt I’ll look at it more tomorrow. After that gets fixed, and pending the bits about asciidoctorj, I think it’s close to ready to push to master and iterate there. Erick > On Nov 12, 2019, at 4:35 PM, Dawid Weiss <[email protected]> wrote: > > Oh, sorry -- I thought you meant this line to be added to the main > dependencies section (not buildScript's). > > D. > > On Tue, Nov 12, 2019 at 10:14 PM Anshum Gupta <[email protected]> wrote: >> >> I didn't add this. This is already in the gradle_8 branch. >> >> What branch are you looking at? Don't you see this too ? >> >> >> On Tue, Nov 12, 2019 at 12:56 PM Dawid Weiss <[email protected]> wrote: >>> >>>> Looking at the following file: >>>> solr/solr-ref-guide/build.gradle >>>> >>>> I see the apparently missing dependency: >>> >>> The buildscript dependency is there because, well, we use it from the >>> script itself. >>> >>> For the "tools" configuration classpath the dependency is not missing, >>> it's correct without the >>> version number (palantir's plugin resolves it): >>> >>> tools('org.asciidoctor:asciidoctorj') >>> >>>> dependencies { >>>> classpath "org.asciidoctor:asciidoctorj:1.6.0-alpha.5" >>>> } >>> >>> This isn't correct, don't add it. The existing config in that script >>> is fine (and works for me); I think Erik's problem is caused by >>> something else. >>> >>> D. >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >> >> >> -- >> Anshum Gupta > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
