If you’ve created a JIRA login, there should be a button on the JIRA about “attach files”. It’s perfectly OK to attach a diff file to the JIRA. It’s preferred to just label it SOLR-#####.patch. Successive versions of the patch should have the exact same name, the old ones are grayed out making it easy to know what the most recent one is without losing the old versions. No big deal though.
If you’re familiar with GIT and have your own fork somewhere, it’s just the usual process of creating a Pull Request from your GitHub repo. If you mention the JIRA when you create the PR by starting the title with “SOLR-#####: any comments you want to make”, it’ll automagically be linked to the JIRA you created. I’ve personally found this a bit confusing because the title you edit is not the first screen when you hit the “create PR” button. If the automagic linking doesn’t work, just paste a link to the PR in the comments. Don’t stress over it, if making a PR is bothersome, just attach a diff file. Either one is fine. Code reviews are easier with a PR, but depending on the size of the patch the utility of easy reviews may be only marginally beneficial. Best, Erick > On Jul 9, 2020, at 11:23 AM, Marco Bolis <[email protected]> wrote: > > Thanks for the answers. > > Excuse me, I'm new to this: how am I supposed to attach the patch / PR to the > issue? > Is it ok to add a diff as attachment? > Should I open the PR and link to it from the issue? > > Thank you very much, regards, > Marco > > Il giorno gio 9 lug 2020 alle ore 17:06 Erick Erickson > <[email protected]> ha scritto: > Marco: > > Thanks for volunteering your fix! > > The best way is to raise a JIRA, see: > https://cwiki.apache.org/confluence/display/solr/HowToContribute#HowToContribute-JIRAtips(ourissue/bugtracker) > and attach a patch or pull request. From there we can discuss/give > feedback/add to the repo, etc. > > Best, > Erick > > > On Jul 9, 2020, at 9:56 AM, Marco Bolis <[email protected]> wrote: > > > > Hello, > > > > I just wrote a patch to make FileListEntityProcessor work by streaming, > > using Java 8 Stream and NIO2, instead of buffering the entire file list in > > memory. > > I had to do it because I had a very large list of files (upwards of 1M) and > > kept going OOM. > > > > I wish I could contribute this patch, if it is deemed useful. > > > > Regards, > > Marco > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
