Thank you very much. I opened PRs to both projects. Regards, Marco Il giorno ven 10 lug 2020 alle ore 05:04 Noble Paul <[email protected]> ha scritto:
> The project will go live anytime from now. It means a user can use it > on any release newer than Solr 8.6 . Even if you provide a fix in the > current 8.x branch, it will not be available before Solr 8.7 release. > OTOH, DIH plugin will have bug fix releases independent of Solr > releases and every user will be able to upgrade their plugin without > upgrading their Solr. > > So, please give PRs to both the external plugin and to Solr > > On Fri, Jul 10, 2020 at 2:58 AM Marco Bolis <[email protected]> wrote: > > > > I see. > > How is the transition going to work Eric? > > I understand the community supported project is going to take over from > Solr 9.0, is that correct? Is DIH code on the Lucene side going to freeze > soon? > > Thank you for the heads up. > > > > Regards, > > Marco > > > > > > Il giorno gio 9 lug 2020 alle ore 18:49 Eric Pugh < > [email protected]> ha scritto: > >> > >> Another thought…. > >> > >> Since DIH is moving to a community supported ( > https://github.com/rohitbemax/dataimporthandler) plugin for Solr, maybe > you want to focus your efforts on that project? > >> > >> One of the reasons for moving DIH into it’s own plugin it to open the > door to more contributions from the community, and this is a good example! > >> > >> > >> > >> On Jul 9, 2020, at 12:09 PM, Erick Erickson <[email protected]> > wrote: > >> > >> If you’ve created a JIRA login, there should be a button on the JIRA > about “attach files”. It’s perfectly OK to attach a diff file to the JIRA. > It’s preferred to just label it SOLR-#####.patch. Successive versions of > the patch should have the exact same name, the old ones are grayed out > making it easy to know what the most recent one is without losing the old > versions. No big deal though. > >> > >> If you’re familiar with GIT and have your own fork somewhere, it’s just > the usual process of creating a Pull Request from your GitHub repo. If you > mention the JIRA when you create the PR by starting the title with > “SOLR-#####: any comments you want to make”, it’ll automagically be linked > to the JIRA you created. I’ve personally found this a bit confusing because > the title you edit is not the first screen when you hit the “create PR” > button. If the automagic linking doesn’t work, just paste a link to the PR > in the comments. > >> > >> Don’t stress over it, if making a PR is bothersome, just attach a diff > file. Either one is fine. Code reviews are easier with a PR, but depending > on the size of the patch the utility of easy reviews may be only marginally > beneficial. > >> > >> Best, > >> Erick > >> > >> On Jul 9, 2020, at 11:23 AM, Marco Bolis <[email protected]> wrote: > >> > >> Thanks for the answers. > >> > >> Excuse me, I'm new to this: how am I supposed to attach the patch / PR > to the issue? > >> Is it ok to add a diff as attachment? > >> Should I open the PR and link to it from the issue? > >> > >> Thank you very much, regards, > >> Marco > >> > >> Il giorno gio 9 lug 2020 alle ore 17:06 Erick Erickson < > [email protected]> ha scritto: > >> Marco: > >> > >> Thanks for volunteering your fix! > >> > >> The best way is to raise a JIRA, see: > https://cwiki.apache.org/confluence/display/solr/HowToContribute#HowToContribute-JIRAtips(ourissue/bugtracker) > and attach a patch or pull request. From there we can discuss/give > feedback/add to the repo, etc. > >> > >> Best, > >> Erick > >> > >> On Jul 9, 2020, at 9:56 AM, Marco Bolis <[email protected]> wrote: > >> > >> Hello, > >> > >> I just wrote a patch to make FileListEntityProcessor work by streaming, > using Java 8 Stream and NIO2, instead of buffering the entire file list in > memory. > >> I had to do it because I had a very large list of files (upwards of 1M) > and kept going OOM. > >> > >> I wish I could contribute this patch, if it is deemed useful. > >> > >> Regards, > >> Marco > >> > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > >> > >> _______________________ > >> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 > | http://www.opensourceconnections.com | My Free/Busy > >> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed > >> This e-mail and all contents, including attachments, is considered to > be Company Confidential unless explicitly stated otherwise, regardless of > whether attachments are marked as such. > >> > > > -- > ----------------------------------------------------- > Noble Paul > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
