Actaully, pretty good. The attached file has a lot of noise in it that’s a
listing of the files that have more or less SuppressWarnings annotations than
last week, the delta is -19. It’s a crude measure, I can replace N
SuppressWarnings in a class with one for the entire class, but it’s also easy
to count. Down is the right direction though.
NamedList accounts for a huge number of SuppressWarnings. I do wonder if we can
figure out better ways to avoid warnings with that class. Other than replace
it. Wholesale surgery to replace it just to avoid warnings is a pretty bad idea
of course….
SuppressWarnings count: last week: 5,372, this week: 5,353, delta -19
Processing file (History bit 3): HOSS-2020-07-13.csv
Processing file (History bit 2): HOSS-2020-07-06.csv
Processing file (History bit 1): HOSS-2020-06-29.csv
Processing file (History bit 0): HOSS-2020-06-22.csv
Number of AwaitsFix: 46 Number of BadApples: 4
**Annotated tests that didn't fail in the last 4 weeks.
**Tests removed from the next two lists because they were specified in
'doNotEnable' in the properties file
MoveReplicaHDFSTest.testNormalFailedMove
**Annotations can be removed from the following tests because they haven't
failed in the last 4 rollups.
**Methods: 0
Raw fail count by week totals, most recent week first (corresponds to bits):
Week: 0 had 19 failures
Week: 1 had 24 failures
Week: 2 had 26 failures
Week: 3 had 26 failures
********Failures in Hoss' reports for the last 4 rollups.
There were 71 unannotated tests that failed in Hoss' rollups. Ordered by the
date I downloaded the rollup file, newest->oldest. See above for the dates the
files were collected
These tests were NOT BadApple'd or AwaitsFix'd
Failures in the last 4 reports..
Report Pct runs fails test
0123 0.9 447 5 TestInPlaceUpdatesDistrib.test
********************************************
DO NOT ENABLE LIST:
MoveReplicaHDFSTest.testFailedMove
MoveReplicaHDFSTest.testNormalFailedMove
TestControlledRealTimeReopenThread.testCRTReopen
TestICUNormalizer2CharFilter.testRandomStrings
TestICUTokenizerCJK
TestImpersonationWithHadoopAuth.testForwarding
TestLTRReRankingPipeline.testDifferentTopN
TestRandomChains
DO NOT ANNOTATE LIST
CdcrBidirectionalTest.testBiDir
IndexSizeTriggerTest.testMergeIntegration
IndexSizeTriggerTest.testMixedBounds
IndexSizeTriggerTest.testSplitIntegration
IndexSizeTriggerTest.testTrigger
InfixSuggestersTest.testShutdownDuringBuild
ShardSplitTest.test
ShardSplitTest.testSplitMixedReplicaTypes
ShardSplitTest.testSplitWithChaosMonkey
Test2BPostings.test
TestLatLonShapeQueries.testRandomBig
TestPackedInts.testPackedLongValues
TestRandomChains.testRandomChainsWithLargeStrings
TestTriggerIntegration.testSearchRate
SuppressWarnings count: last week: 5,372, this week: 5,353, delta -19
*************** Files with increased @SuppressWarnings annotations:
Suppress count increase in:
solr/core/src/java/org/apache/solr/search/facet/SlotAcc.java. Was: 3, now: 5
Suppress count increase in:
solr/core/src/test/org/apache/solr/search/facet/TestCloudJSONFacetSKGEquiv.java.
Was: 5, now: 11
Suppress count increase in:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java.
Was: 12, now: 13
*************** Files with decreased @SuppressWarnings annotations:
Suppress count decrease in:
solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/ContextImpl.java.
Was: 5, now: 4
Suppress count decrease in:
solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/XPathEntityProcessor.java.
Was: 8, now: 7
Suppress count decrease in:
solr/core/src/java/org/apache/solr/handler/IndexFetcher.java. Was: 19, now: 13
Suppress count decrease in:
solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java. Was: 14,
now: 13
Suppress count decrease in:
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java.
Was: 1, now: 0
Suppress count decrease in:
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java.
Was: 7, now: 6
Suppress count decrease in:
solr/core/src/java/org/apache/solr/search/function/distance/GeoDistValueSourceParser.java.
Was: 2, now: 1
Suppress count decrease in:
solr/core/src/java/org/apache/solr/security/AuthorizationContext.java. Was: 1,
now: 0
Suppress count decrease in:
solr/core/src/java/org/apache/solr/security/KerberosPlugin.java. Was: 1, now: 0
Suppress count decrease in:
solr/core/src/java/org/apache/solr/security/RuleBasedAuthorizationPluginBase.java.
Was: 4, now: 3
Suppress count decrease in:
solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java. Was: 5, now: 4
Suppress count decrease in:
solr/core/src/test/org/apache/solr/cloud/api/collections/CollectionsAPIDistributedZkTest.java.
Was: 4, now: 3
Suppress count decrease in:
solr/core/src/test/org/apache/solr/cloud/api/collections/TestCollectionAPI.java.
Was: 54, now: 53
Suppress count decrease in:
solr/core/src/test/org/apache/solr/response/TestPushWriter.java. Was: 2, now: 1
Suppress count decrease in:
solr/core/src/test/org/apache/solr/security/BaseTestRuleBasedAuthorizationPlugin.java.
Was: 7, now: 2
Suppress count decrease in:
solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/PolicyHelper.java.
Was: 5, now: 4
Suppress count decrease in:
solr/solrj/src/java/org/apache/solr/common/cloud/CompositeIdRouter.java. Was:
1, now: 0
Suppress count decrease in:
solr/solrj/src/java/org/apache/solr/common/cloud/DocRouter.java. Was: 2, now: 1
Suppress count decrease in:
solr/test-framework/src/java/org/apache/solr/handler/component/TrackingShardHandlerFactory.java.
Was: 2, now: 1
Processing file (History bit 3): HOSS-2020-07-13.csv
Processing file (History bit 2): HOSS-2020-07-06.csv
Processing file (History bit 1): HOSS-2020-06-29.csv
Processing file (History bit 0): HOSS-2020-06-22.csv
Number of AwaitsFix: 46 Number of BadApples: 4
**Annotated tests that didn't fail in the last 4 weeks.
**Tests removed from the next two lists because they were specified in
'doNotEnable' in the properties file
MoveReplicaHDFSTest.testNormalFailedMove
**Annotations can be removed from the following tests because they haven't
failed in the last 4 rollups.
**Methods: 0
Raw fail count by week totals, most recent week first (corresponds to bits):
Week: 0 had 19 failures
Week: 1 had 24 failures
Week: 2 had 26 failures
Week: 3 had 26 failures
********Failures in Hoss' reports for the last 4 rollups.
There were 71 unannotated tests that failed in Hoss' rollups. Ordered by the
date I downloaded the rollup file, newest->oldest. See above for the dates the
files were collected
These tests were NOT BadApple'd or AwaitsFix'd
Failures in the last 4 reports..
Report Pct runs fails test
0123 0.9 447 5 TestInPlaceUpdatesDistrib.test
********************************************
Failures over the last 4 weeks, but not every week. Ordered most-recent first:
Report Pct runs fails test
012 4.5 77 6 ShardSplitTest.testSplitWithChaosMonkey
012 100.0 18 17 SharedFSAutoReplicaFailoverTest.test
012 4.2 306 14 TestContainerPlugin.testApiFromPackage
0 23 0.9 349 10 RollingRestartTest.test
0 2 2.3 51 2 TestCircuitBreaker.testResponseWithCBTiming
0 5.3 113 6
CollectionTooManyReplicasTest.testAddTooManyReplicas
0 9.5 21 2 HdfsWriteToMultipleCollectionsTest.test
0 0.9 110 1 ShardRoutingTest.test
0 5.0 20 1 StressHdfsTest.test
0 4.7 43 2
TestCircuitBreaker.testBuildingMemoryPressure
0 0.9 110 1 TestDistributedGrouping.test
0 16.7 24 4
TestIndexingSequenceNumbers.testStressConcurrentCommit
0 4.7 129 6
TestSimpleTextTermVectorsFormat.testPostingsEnumOffsets
0 32.4 34 11
TestSimpleTextTermVectorsFormat.testRamBytesUsed
0 18.2 11 2 ThreadDumpHandlerTest.testMonitor
0 27.3 11 3 ThreadDumpHandlerTest.testOwnableSync
123 15.8 305 32 TestReRankQParserPlugin.testMinExactCount
12 7.6 420 194 DebugComponentTest.testBasicInterface
12 7.6 420 194 DebugComponentTest.testPerItemInterface
12 0.8 235 2
DocValuesNotIndexedTest.testGroupingDVOnlySortFirst
1 3 0.8 230 2
TestQueryingOnDownCollection.testQueryToDownCollectionShouldFailFast
1 1.6 122 2 PeerSyncWithLeaderTest.test
1 0.8 131 1 ShardSplitTest.testSplitShardWithRule
1 0.8 126 1
TestBlockJoin.testMultiChildQueriesOfDiffParentLevels
1 1.6 127 2 TestDemoParallelLeafReader.testBasic
1 1.6 127 2
TestDemoParallelLeafReader.testBasicMultipleSchemaGens
1 1.6 127 2 TestDemoParallelLeafReader.testRandom
1 1.6 127 2
TestDemoParallelLeafReader.testRandomMultipleSchemaGens
1 0.8 126 1
TestDemoParallelLeafReader.testRandomMultipleSchemaGensSameField
1 0.8 120 1 TestSimScenario.testSuggestions
1 52.6 38 20 TestStressThreadBackup.testCoreAdminHandler
1 52.6 38 20
TestStressThreadBackup.testReplicationHandler
1 0.9 117 1 TestTlogReplica.testRemoveLeader
23 0.9 221 2 AutoScalingHandlerTest.testReadApi
23 17.1 301 68
CurrencyRangeFacetCloudTest.testJsonRangeFacetWithSubFacet
23 17.2 56 11 HdfsSyncSliceTest.test
23 0.9 224 2 TestSimDistributedQueue.testPeekElements
2 0.9 113 1
AutoScalingHandlerTest.testSuggestionsWithPayload
2 30.6 36 11
TestBinaryDocValuesUpdates.testTonsOfUpdates
2 3.1 131 4
TestBinaryDocValuesUpdates.testUpdateSegmentWithPostingButNoDocValues
2 1.6 125 2
TestIndexWriterDelete.testDeleteAllNoDeadLock
2 0.8 125 1
TestIndexWriterDelete.testErrorInDocsWriterAdd
2 0.8 125 1 TestIndexWriterDelete.testSimpleCase
2 8.7 126 11 TestMultiWordSynonyms.testPf
2 5.5 127 7
TestRandomChains.testRandomChainsWithLargeStrings
2 1.7 121 2
TestSearcherManager.testConcurrentIndexCloseSearchAndRefresh
2 8.4 131 11
TestXYMultiPointShapeQueries.testLowCardinalityShapeManyTimes
3 0.9 108 1 AutoscalingHistoryHandlerTest.testHistory
3 4.0 25 1 ForceLeaderTest.testReplicasInLowerTerms
3 0.9 111 1 HttpPartitionWithTlogReplicasTest.test
3 1.4 74 1
LegacyCloudClusterPropTest.testCreateCollectionSwitchLegacyCloud
3 1.8 114 2 SystemCollectionCompatTest.testBackCompat
3 15.2 112 17 TestAllFilesDetectTruncation.test
3 12.1 91 11 TestCloudJSONFacetSKGEquiv.testRandom
3 9.2 120 11 TestIndexWriterOnVMError.testOOM
3 0.9 110 1 TestNRTReaderWithThreads.testIndexing
3 1.8 111 2 TestOfflineSorter.testThreadSafety
3 0.9 108 1
TestPullReplicaErrorHandling.testCantConnectToLeader
3 0.9 111 1 TestStressNRT.test
3 4.5 22 1
TestXYMultiPolygonShapeQueries.testRandomBig
***********************Annotations report
*****************AwaitsFix Annotations:
************Lucene AwaitsFix
TestAllFilesDetectBitFlips.TestAllFilesDetectBitFlips suite
@AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/LUCENE-9356";)
TestAllFilesDetectTruncation.TestAllFilesDetectTruncation suite
@AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/LUCENE-9409";)
TestControlledRealTimeReopenThread.testCRTReopen
@AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/LUCENE-5737";)
TestICUNormalizer2CharFilter.testRandomStrings
@AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/LUCENE-5595";)
TestICUTokenizerCJK.TestICUTokenizerCJK suite
@AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/LUCENE-8222";)
TestMoreLikeThis.testMultiFieldShouldReturnPerFieldBooleanQuery
@AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/LUCENE-7161";)
************Solr AwaitsFix
AutoAddReplicasIntegrationTest.testRapidStopStartStopWithPropChange
@AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-13811";)
CdcrBidirectionalTest.testBiDir
@AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/SOLR-12524";)
CdcrBootstrapTest.testBootstrapWithContinousIndexingOnSourceCluster
@AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/SOLR-12028";)
CollectionsAPISolrJTest.testCreateAndDeleteShard
@AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/SOLR-13021";)
ComputePlanActionTest.testNodeLost
@LuceneTestCase.AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028";)
ConcurrentCreateRoutedAliasTest.ConcurrentCreateRoutedAliasTest suite
@LuceneTestCase.AwaitsFix(bugUrl =
"https://issues.apache.org/jira/browse/SOLR-12386";) // "Can't find resource"
LeaderTragicEventTest.LeaderTragicEventTest suite
@AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-13237";)
MoveReplicaHDFSTest.MoveReplicaHDFSTest suite
@AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-13924";)
MoveReplicaHDFSTest.testFailedMove
@AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-12080";) //
added 03-Oct-2018
ReplaceNodeNoTargetTest.ReplaceNodeNoTargetTest suite
@LuceneTestCase.AwaitsFix(bugUrl =
"https://issues.apache.org/jira/browse/SOLR-11067";)
ReplaceNodeNoTargetTest.test
@LuceneTestCase.AwaitsFix(bugUrl =
"https://issues.apache.org/jira/browse/SOLR-11067";)
RoutedAliasUpdateProcessorTest.alias,
@org.apache.lucene.util.LuceneTestCase.AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-13696";)
SSLMigrationTest.SSLMigrationTest suite
@AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028";) //
17-Mar-2018
SaslZkACLProviderTest.testSaslZkACLProvider
@AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/SOLR-13075";)
ScheduledMaintenanceTriggerTest.testInactiveShardCleanup
@AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028";) //
17-Mar-2018
ScheduledTriggerTest.testTrigger
@AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028";) //
added 20-Sep-2018
SearchRateTriggerIntegrationTest.testDeleteNode
@AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-13163";)
SearchRateTriggerTest.testTrigger
@AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028";)
SolrExporterIntegrationTest.SolrExporterIntegrationTest suite
@org.apache.lucene.util.LuceneTestCase.AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-13786";)
Tagger2Test.testStopWords
@AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/LUCENE-8344";)
TestHierarchicalDocBuilder.testThreeLevelHierarchy
@AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/SOLR-12801";) //
this test fails easily under beasting
TestImpersonationWithHadoopAuth.testForwarding
@AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/HADOOP-9893";)
TestJsonFacetRefinement.testIndexAscRefineConsistency
@AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-14595";)
TestJsonFacetRefinement.testProcessEmptyRefinement
@AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-12556";)
TestJsonFacetRefinement.testSortedSubFacetRefinementWhenParentOnlyReturnedByOneShardProcessEmpty
@AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-12556";)
TestLTRReRankingPipeline.testDifferentTopN
@AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/SOLR-11134";)
TestMinMaxOnMultiValuedField.testDoubleFieldCache
@AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/LUCENE-6709";)
TestMinMaxOnMultiValuedField.testFloatFieldCache
@AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/LUCENE-6709";)
TestMinMaxOnMultiValuedField.testIntFieldCache
@AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/LUCENE-6709";)
TestMinMaxOnMultiValuedField.testLongFieldCache
@AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/LUCENE-6709";)
TestPullReplica.TestPullReplica suite
@AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028";)
TestSimComputePlanAction.testNodeLost
@AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/SOLR-12028";) //
if you beast this, eventually you will see
TestSimExtremeIndexing.TestSimExtremeIndexing suite
@org.apache.lucene.util.LuceneTestCase.AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-12923";)
TestSimLargeCluster.testAddNode
@AwaitsFix( bugUrl = "https://issues.apache.org/jira/browse/SOLR-14275";)
TestSimLargeCluster.testBasic
@AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028";) //
this test hits a timeout easily
TestStressRecovery.TestStressRecovery suite
@LuceneTestCase.AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028";)
// 6-Sep-2018
TestTlogReplayVsRecovery.TestTlogReplayVsRecovery suite
@AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-13486;https://issues.apache.org/jira/browse/SOLR-14183";)
ThreadDumpHandlerTest.ThreadDumpHandlerTest suite
@SolrTestCaseJ4.AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-14635";)
TimeRoutedAliasUpdateProcessorTest.testDateMathInStart
@AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-13943";)
TriLevelCompositeIdRoutingTest.test
@AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/SOLR-13369";)
*****************BadApple Annotations:
************Lucene BadApple
************Solr BadApple
MoveReplicaHDFSTest.testNormalFailedMove
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028";) //
14-Oct-2018
SharedFSAutoReplicaFailoverTest.SharedFSAutoReplicaFailoverTest suite
@LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028";)
// added 20-Jul-2018
TimeRoutedAliasUpdateProcessorTest.TimeRoutedAliasUpdateProcessorTest suite
@LuceneTestCase.BadApple(bugUrl =
"https://issues.apache.org/jira/browse/SOLR-13059";)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
