[
https://issues.apache.org/jira/browse/LUCENE-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109768#comment-13109768
]
Shai Erera commented on LUCENE-3445:
------------------------------------
This is great Mike !
I reviewed SearcherManager and have a comment about the TODO on whether or not
to call warm in the ctor. If an extending class relies on some internal members
to be initialized before warm() can safely be called, then this will lead to
exceptions. I think that warm() should not be called in the ctor, or at least
add a ctor which accepts a boolean doWarm, while the other ctors call it with
'true'.
Calling warm() in the ctor is useful if one wants to warm the IndexSearcher
instance before SearcherManager is ready for use. So perhaps an additional ctor
with the boolean gives the most flexibility.
Also, I remember there was a ctor which took IndexWriter, to allow for an
NRT-SearcherManager. What happened to it? :)
> Add SearcherManager, to manage IndexSearcher usage across threads and reopens
> -----------------------------------------------------------------------------
>
> Key: LUCENE-3445
> URL: https://issues.apache.org/jira/browse/LUCENE-3445
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3445.patch
>
>
> This is a simple helper class I wrote for Lucene in Action 2nd ed.
> I'd like to commit under Lucene (contrib/misc).
> It simplifies using & reopening an IndexSearcher across multiple
> threads, by using IndexReader's ref counts to know when it's safe
> to close the reader.
> In the process I also factored out a test base class for tests that
> want to make lots of simultaneous indexing and searching threads, and
> fixed TestNRTThreads (core), TestNRTManager (contrib/misc) and the new
> TestSearcherManager (contrib/misc) to use this base class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
