[
https://issues.apache.org/jira/browse/LUCENE-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112918#comment-13112918
]
Simon Willnauer commented on LUCENE-3445:
-----------------------------------------
bq. Well, warm() is a no-op if you don't extend SearcherManager, so, if you
extend, you'd impl warm, and then in your ctor you should call warm on the
initial searcher if need be. Definitely trappy so we should jdoc that
subclass's ctor must handle warming initial searcher....
it seems pretty trappy to have this in the ctor though. Since this is a noop by
default and it requires subclassing to do something with it it might be worth
introducing a SearchWarmer interface and simply pass this interface into the
ctor ie. have two ctors where by default we pass a noop warmer?
> Add SearcherManager, to manage IndexSearcher usage across threads and reopens
> -----------------------------------------------------------------------------
>
> Key: LUCENE-3445
> URL: https://issues.apache.org/jira/browse/LUCENE-3445
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3445.patch
>
>
> This is a simple helper class I wrote for Lucene in Action 2nd ed.
> I'd like to commit under Lucene (contrib/misc).
> It simplifies using & reopening an IndexSearcher across multiple
> threads, by using IndexReader's ref counts to know when it's safe
> to close the reader.
> In the process I also factored out a test base class for tests that
> want to make lots of simultaneous indexing and searching threads, and
> fixed TestNRTThreads (core), TestNRTManager (contrib/misc) and the new
> TestSearcherManager (contrib/misc) to use this base class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
