I will defer to the sophisticated gradle policeman on this!
> On 25 May 2021, at 18:40, Uwe Schindler <u...@thetaphi.de> wrote:
>
> Hi,
>
> the problem is that the RAT task has only some patterns for filenames as
> input, but no actual @InputDirectory. If the files change, nothing changes
> from Gradle's point of view.
>
> The validation/rat-sources.gradle and its inner class "RatTask" must at least
> declare @InputDirectory with a default value of ${project.projectDir}. This
> would cause any change to retrigger the task.
>
> To make it more professional, it should declare a FileCollection and apply
> the patterns, but that's more complicated as this task just wraps the native
> Ant RAT task.
>
> I can fix this (must be done for Solr and Lucene, both have the problem).
>
> Uwe
>
> -----
> Uwe Schindler
> Achterdiek 19, D-28357 Bremen
> https://www.thetaphi.de
> eMail: u...@thetaphi.de
>
>> -----Original Message-----
>> From: Alan Woodward <romseyg...@gmail.com>
>> Sent: Tuesday, May 25, 2021 7:26 PM
>> To: dev@lucene.apache.org
>> Subject: Misconfigured gradle rat inputs?
>>
>> There’s a subject line I never thought I’d type :)
>>
>> Firstly: can I say how much I appreciate all the work that’s gone into the
>> gradle
>> build? I’ve been doing lots of small PRs for the spans-to-queries work and
>> being
>> able to run checks multiple times in an extremely efficient manner has been a
>> life saver. Massive thanks to Dawid, and also to Robert for all the work on
>> speeding up tests.
>>
>> I think may have found a bug in the input configuration for our license
>> header
>> checks. Thanks to the new build, I have been running `./gradlew check`
>> before
>> pushing code, but it has let through files with missing headers a few times,
>> which were subsequently caught by the GitHub action running on the PR.
>>
>> So I tried the following:
>> - start a new git branch
>> - run ./gradlew rat -> everything should pass
>> - edit one of the files to remove the license header
>> - run ./gradlew rat -> still passes!
>> - run ./gradlew clean
>> - run ./gradlew rat -> now I get an error
>>
>> This looks to me like the fileset that the rat task is looking at is not set
>> up
>> correctly, but I don’t know enough gradle to actually work out what is wrong
>> and what the fix should be.
>>
>> - A
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
>> For additional commands, e-mail: dev-h...@lucene.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> For additional commands, e-mail: dev-h...@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
