It's the exact same thing as in Elasticsearch, as we inherit some code for ES in CrateDB: https://github.com/crate/crate/pull/15408 so don't know if it worths adding it, but your call.
Just for the full context, for CrateDB we have also an issue with the toolchain maven plugin since it downloaded the latest 22 JDK, although originally pinned to `22.0.1`, so we've hit the bug without doing an an explicit upgrade of the JDK. Thank you! On Wed, Jan 24, 2024 at 4:32 PM Chris Hegarty <christopher.hega...@elastic.co.invalid> wrote: > Hi Marios, > > If you have a link to the CrateDB issue, I’ll add it to JDK-8323659. > > -Chris. > > > On 24 Jan 2024, at 14:26, Chris Hegarty <christopher.hega...@elastic.co> > wrote: > > > > Hi Marios, > > > > Thanks for raising awareness of this JDK bug. > > > > Just to be clear, and for other readers of this list, the JDK bug is > orthogonal to whether or not we include support for Java 22 in a future > Lucene release. > > > >> On 24 Jan 2024, at 14:15, Marios Trivyzas <mat...@gmail.com> wrote: > >> > >> Hi, > >> > >> Just an FYI regarding Java22. > >> In CrateDB we experienced issues with a bug: > https://bugs.openjdk.org/browse/JDK-8323659 > >> From a quick search, haven't seen usage of `LinkedTransferQueue` in > Lucene, so just wanted to share the issue. > > > > JDK-8323659 was discovered and fixed in a JDK 22 Early Access build - it > will not be in any GA release of 22. > > > > Unfortunately, JDK-8323659 found its way into a bugfix release of the > JDK, 21.0.2. Since it was found late in the release cycle, 21.0.2 shipped > with it. It was later fixed in the yet-to-be-released 21.0.3. > > > > I’ve seen no issues in Lucene because of JDK-8323659. However, we have > seen issues in Elasticsearch, see > https://github.com/elastic/elasticsearch/pull/104347. Were we needed to > workaround JDK-8323659 in order to adopt JDK 21.0.2. > > > > JDK-8323659 is a bit of a sad story. I really wish we could have had a > respin of JDK 21.0.2, but that was not possible at the time :-( > > > > -Chris. > > > >> > >> Cheers > >> -- Marios > >> > >> On Wed, Jan 24, 2024 at 4:08 PM Chris Hegarty > <christopher.hega...@elastic.co.invalid> wrote: > >> Hi Uwe, > >> > >>> On 24 Jan 2024, at 13:29, Uwe Schindler <u...@thetaphi.de> wrote: > >>> > >>> Hi, > >>> > >>> Now I understand why you asked yesterday in the Java 22 PR. > >> > >> :-) I was just gathering my thoughts and considering what options we > have relating to releases (bugfix or minor). > >> > >>> Do you think we should add Java 22 support for MMAP and Vectors? > >> > >> No. Let’s do a 9.9.2 with just the two aforementioned bug fixes. We can > later do a 9.10, some time in late February to early March, in order to > pick up the Java 22 and other changes. > >> > >>> It is a bit risky, because API may still change, but the worst that > could happen is that people need to pass a sysprop in Java 22 to disable > broken MMAP (if everything goes wrong). > >>> > >>> So what do you think? Should we merge in Java 22 support or not? It's > a bugfix release, so I am not super happy to take any risks. > >> > >> Agree. Let’s lower the risk. We’ll stay the coarse for Java 22 support > in 9.10, as would be the case if 9.9.2 was not a thing. > >> > >> -Chris. > >> > >>> Uwe > >>> > >>> Am 23.01.2024 um 18:36 schrieb Chris Hegarty: > >>>> Hi, > >>>> > >>>> We’ve encounter a serious issue with the recent Lucene 9.9.1 release, > which warrants a 9.9.2. > >>>> > >>>> The issue is a NPE when sampling for quantization in > Lucene99HnswScalarQuantizedVectorsFormat [1]. Thankfully Ben has already > resolved the issue, and backported it to the appropriate branches. > >>>> > >>>> I don’t see any other potential issues that would warrant being > pulled into this release. > >>>> > >>>> I’m happy to be Release Manager for 9.9.2 (given my recent experience > on 9.9.1). I’ll start the release process tomorrow and notify this list > when artifacts are ready. > >>>> > >>>> Thanks, > >>>> -Chris. > >>>> > >>>> [1] https://github.com/apache/lucene/pull/13027 > >>>> --------------------------------------------------------------------- > >>>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > >>>> For additional commands, e-mail: dev-h...@lucene.apache.org > >>>> > >>> -- > >>> Uwe Schindler > >>> Achterdiek 19, D-28357 Bremen > >>> https://www.thetaphi.de > >>> eMail: u...@thetaphi.de > >>> > >>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > >>> For additional commands, e-mail: dev-h...@lucene.apache.org > >>> > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > >> For additional commands, e-mail: dev-h...@lucene.apache.org > >> > >> > >> > >> -- > >> Marios > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org > > -- Marios
