Thanks for driving this release process Adrien, and everyone for helping to resolve the blockers! More comments below:
On Mon, Sep 9, 2024 at 1:45 PM Adrien Grand <jpou...@gmail.com> wrote: I just reviewed the humongous PR that migrates more classes to records > <https://github.com/apache/lucene/pull/13328>, it looks pretty good to > me. If someone can look at my comments (hopefully much quicker than > reviewing the whole PR!), I would appreciate it. > +1 to merge this. I would like to get support for intra-segment search concurrency > <https://github.com/apache/lucene/pull/13542> in, as it is breaking > enough that we could not easily introduce it in a minor later on. It seems > to be almost ready, so hopefully it will get merged before feature freeze > next week? > +1 > I'm not clear if someone is actively looking into the recall issues with > 8-bit quantization <https://github.com/apache/lucene/issues/13519>? > If nobody jumps on this in the next day or so, I'll work up a PR to remove int8 for now. Especially with possible RaBitQ (aside: I am not loving this sudden trend for acronyms to be case sensitive like this!!) coming, maybe the (less impactful?) scalar quantization will become less interesting... Mike McCandless http://blog.mikemccandless.com >
