[ 
https://issues.apache.org/jira/browse/LUCENE-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117158#comment-13117158
 ] 

Robert Muir commented on LUCENE-3474:
-------------------------------------

Simon i have *never* seen code with this pattern before.

The chance to introduce error with that crazy-builder-like-thing is tremendous, 
because its unnatural.
(In fact i think i spotted some things doing this patch, for other issues)

What is wrong with normal java objects?
                
> pass liveDocs Bits down in scorercontext, instead of Weights pulling from the 
> reader 
> -------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3474
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3474
>             Project: Lucene - Java
>          Issue Type: Task
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>         Attachments: LUCENE-3474.patch, LUCENE-3474.patch
>
>
> Spinoff from LUCENE-1536, this would allow filters to work in a more flexible 
> way (besides just cleaning up)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to