[
https://issues.apache.org/jira/browse/LUCENE-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117167#comment-13117167
]
Simon Willnauer commented on LUCENE-3474:
-----------------------------------------
bq. Why? because I disagree with you? Thats pretty natural man, normal for
people to disagree on opinions.
because I don't see that you are going away from your opinion whatever I say.
You made clear you don't want to have any builder pattern in lucene so what is
the point of discussing then. I need to put up my own patch which uses the
builder to make my objections being in the patch obviously which is not what I
am used to. Usually we try to find a compromise and by iterating, right? Each
time this pattern comes up there is no way that you move a tiny bit from your
opinion just because you don't like it. Well I don't like things people suggest
from a code syte perspective but it makes sense very often, so I change it. I
don't see why this needs to go for rounds and rounds of fighting here. We did
this for a reason when ScorerContext has introduced, it served as a little DSL
on top of it enforcing immutability. if you want to have Bit mandatory you
should just do something like
ScorereContext.create(delDocs).topLevel(true).outOfOrder(false) which makes
very clear what you want rather than new ScoreContext(delDocs, true, false) and
we gonna have more boolean params here in the future.
> pass liveDocs Bits down in scorercontext, instead of Weights pulling from the
> reader
> -------------------------------------------------------------------------------------
>
> Key: LUCENE-3474
> URL: https://issues.apache.org/jira/browse/LUCENE-3474
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-3474.patch, LUCENE-3474.patch
>
>
> Spinoff from LUCENE-1536, this would allow filters to work in a more flexible
> way (besides just cleaning up)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
