[ 
https://issues.apache.org/jira/browse/LUCENE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121410#comment-13121410
 ] 

Michael McCandless commented on LUCENE-3433:
--------------------------------------------

bq. SortedSource or rather its impls. are hairy and horribly inefficient during 
merge. 

Well let's address that ("remove SortedSource") under a different issue?  I 
don't think we should remove them here because it's unrelated (there are other 
great simplifications here).

I'm all for simplifying, but not if we lose good functionality (cut into the 
bone).

Loading everything into heap can be solved, but, I think is relatively low 
priority because that's how the search app would use sorted DV at search time 
anyway.  Ie, an app sets this on their "country" field because they know they 
want to sort by "country" at search time, and they will load the DV into RAM at 
search time.  We only hold this RAM allocated while we merge the one field, 
then it's freed, so if multiple DV sort fields are used, merging takes less RAM 
than searching.  I think the merge RAM usage is relatively minor.

The SortedSource has a simple API (just like FC.DocTermsIndex): getOrd(int 
docID), getValue(int ord).  I don't see why this is adding complexity to DV.
                
> Random access non RAM resident IndexDocValues (CSF)
> ---------------------------------------------------
>
>                 Key: LUCENE-3433
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3433
>             Project: Lucene - Java
>          Issue Type: New Feature
>    Affects Versions: 4.0
>            Reporter: Yonik Seeley
>             Fix For: 4.0
>
>         Attachments: LUCENE-3433.patch, LUCENE-3433.patch
>
>
> There should be a way to get specific IndexDocValues by going through the 
> Directory rather than loading all of the values into memory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to