[
https://issues.apache.org/jira/browse/SOLR-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125990#comment-13125990
]
Hoss Man commented on SOLR-2487:
--------------------------------
Jan: looks fine to me
I'm not a huge fan of the name "dist-war-minimal" since it's only excluding log
related jars (a truly minimal war might eliminate *all* jars and let you add
the ones you need to the classpath) but functionally it seems fine. (maybe
"dist-war-no-slf4j")
Even with the explicit ant target, it still seems like making the properties
overridable at runtime would be helpful for people who care about this sort of
war customization/minimalization ... it looks like the patch would let you do
this if you run "cd solr/webapp && ant dist -Dsolr.war.suffix=-micro
-Dexclude.from.war=\*.jar" but not if you just run "cd solr/ && ant dist
-Dsolr.war.suffix=-micro -Dexclude.from.war=\*.jar"
... but i dunno, maybe it doesn't matter. In any situation where i would
consider customizing the war in *any* of the ways we're talking about in this
issue i would do it in my own build.xml anyway, so maybe it's not worth the
extra complexity to the solr build.xml (i would argue that about the entire
issue -- but i get that slf4j is a particular pain point for some people)
> Do not include slf4j-jdk14 jar in WAR
> -------------------------------------
>
> Key: SOLR-2487
> URL: https://issues.apache.org/jira/browse/SOLR-2487
> Project: Solr
> Issue Type: Improvement
> Components: Build
> Affects Versions: 3.2, 4.0
> Reporter: Jan Høydahl
> Labels: logging, slf4j
> Attachments: SOLR-2487.patch
>
>
> I know we've intentionally bundled slf4j-jdk14-1.5.5.jar in the war to help
> newbies get up and running. But I find myself re-packaging the war for every
> customer when adapting to their choice of logger framework, which is
> counter-productive.
> It would be sufficient to have the jdk-logging binding in example/lib to let
> the example and tutorial still work OOTB but as soon as you deploy solr.war
> to production you're forced to explicitly decide what logging to use.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
