[ 
https://issues.apache.org/jira/browse/LUCENE-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138314#comment-13138314
 ] 

Uwe Schindler commented on LUCENE-3539:
---------------------------------------

I agree with Robert, adding this to IndexInput is stupid.

I think, only adding the file name as done before should be fine. There are 
only few places where we pass null as file name to the exception (whoch may be 
fixed). Passing the whole directory name is in my opinion useless. Its up to 
the implementation using lucene to keep track of its directory name (when it 
opens a IndexReader it already knows its dir name).

I would close this as won't fix and maybe only fix the remaining places that 
misses the file name (e.g. SegmentTermsEnumReader).
                
> IndexFormatTooOld/NewExc should try to include fileName + directory when 
> possible
> ---------------------------------------------------------------------------------
>
>                 Key: LUCENE-3539
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3539
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 3.5, 4.0
>
>         Attachments: LUCENE-3539.patch
>
>
> (Spinoff from http://markmail.org/thread/t6s7nn3ve765nojc )
> When we throw a too old/new exc we should try to include the full path to the 
> offending file, if possible.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to