[ 
https://issues.apache.org/jira/browse/LUCENE-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143317#comment-13143317
 ] 

Robert Muir commented on LUCENE-3539:
-------------------------------------

Patch looks good, only one minor idea for improvement:

When we throw "read past EOF" I think we should throw java.io.EOFException 
(extends IOException) rather than a generic one?
                
> IndexFormatTooOld/NewExc should try to include fileName + directory when 
> possible
> ---------------------------------------------------------------------------------
>
>                 Key: LUCENE-3539
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3539
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 3.5, 4.0
>
>         Attachments: LUCENE-3539.patch, LUCENE-3539.patch
>
>
> (Spinoff from http://markmail.org/thread/t6s7nn3ve765nojc )
> When we throw a too old/new exc we should try to include the full path to the 
> offending file, if possible.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to