[
https://issues.apache.org/jira/browse/SOLR-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154551#comment-13154551
]
Hoss Man commented on SOLR-2772:
--------------------------------
I guess i don't understand what exactly you mean by "original".
The *original* circa Solr 1.1 hand rolled code for dealing with dates had all
sorts of bugs, fixed in various ways over the years -- this particular patch
fixed two bugs in DateField (related to years 0001-1000 and millis on years
before the epoch) and corrected the fact that TextResponseWriter was
erroneously not using the well tested formatting code in DateField -- so it was
still susceptible to some of those old bugs. (do i have the full list of those
bugs handy: no, but if you're interested you can search Jira for them)
If you want to re-write this to be hand rolled go ahead, but please do so in
the DateField code (and don't just revert the changes to TextResponseWriter)
since tests directly against DateField are where most of the Unit testing of
parsing/formatting esoteric dates live -- if you keep all those tests happy
(w/o writting yet another new set of parse/format methods) then i'll happily
welcome whatever high-performance hand rolled solution you have.
> DateField parsing/formatting issues of years 0001-1000
> ------------------------------------------------------
>
> Key: SOLR-2772
> URL: https://issues.apache.org/jira/browse/SOLR-2772
> Project: Solr
> Issue Type: Sub-task
> Reporter: Hoss Man
> Assignee: Hoss Man
> Fix For: 3.5, 4.0
>
>
> see parent task for background
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
