[
https://issues.apache.org/jira/browse/LUCENE-3590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156780#comment-13156780
]
Robert Muir commented on LUCENE-3590:
-------------------------------------
well here i'm just trying to prevent BytesRef/IntsRef/CharsRef from being crazy
classes where its confusing what the methods do... oh wait, its too late.
I think the key issue is sometimes they are used like array/stringbuilder, but
other times they are used like bytebuffer?
I'm not going to push the issue so far to say we should remove BytesRef
entirely and just use ByteBuffer but i also don't think that should be totally
out of the question?
For now, since we support being a ByteBuffer and also a ByteArrayBuilder, i
want to first just distinguish the deep copying from the shallow copying before
trying to unbreak stuff.
> minimize bytesref to be a ref to a byte[]
> -----------------------------------------
>
> Key: LUCENE-3590
> URL: https://issues.apache.org/jira/browse/LUCENE-3590
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 4.0
> Reporter: Robert Muir
> Priority: Blocker
>
> Setting this as blocker for 4.0, as this class is used in every API there.
> Currently this API is a little of a everything, sometimes its like a
> stringbuffer, it
> does numeric conversions, all kinds of stuff.
> We need this to be a ref to a byte[], nothing else. This other stuff can go
> somewhere else.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
