[ 
https://issues.apache.org/jira/browse/LUCENE-3590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157146#comment-13157146
 ] 

Robert Muir commented on LUCENE-3590:
-------------------------------------

Don't worry, i will fix in 3.x too. Its good that its internal for now, because 
the api needs cleanup.

i would like to remove deep copying, but again, as i said at least 2 times 
before here, the first step is to clearly mark what is deep copying and what is 
normal use.

This way the uses are not intermixed confusingly in the source code. This makes 
it at least possible to fix.
                
> minimize bytesref to be a ref to a byte[]
> -----------------------------------------
>
>                 Key: LUCENE-3590
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3590
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>            Priority: Blocker
>         Attachments: LUCENE-3590_copyCtor.patch, LUCENE-3590_with_clone.patch
>
>
> Setting this as blocker for 4.0, as this class is used in every API there.
> Currently this API is a little of a everything, sometimes its like a 
> stringbuffer, it
> does numeric conversions, all kinds of stuff.
> We need this to be a ref to a byte[], nothing else. This other stuff can go 
> somewhere else.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to