[ 
https://issues.apache.org/jira/browse/SOLR-2976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171288#comment-13171288
 ] 

Hoss Man commented on SOLR-2976:
--------------------------------

bq. it's been a bit abused and actually may no longer be needed.

Good point ... other then the two uses i mentioned, i think LukeRequestHandler 
is the only other place (outside of FieldType) in Solr that even cares about 
FieldType.isTokenized()

(other things internally to FieldType care about the TOKENIZED property, but 
even that isn't used by much other then TextField)
                
> TrieField.isTokenized returns true regardless of precisionStep
> --------------------------------------------------------------
>
>                 Key: SOLR-2976
>                 URL: https://issues.apache.org/jira/browse/SOLR-2976
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 3.5
>            Reporter: Hoss Man
>
> regardless of the precisionStep used, TrieField.isTokenized is hardcoded to 
> return true -- so even if a user has something like this in their schema...
> {code}
> <fieldType name="long" class="solr.TrieLongField" precisionStep="0" 
> omitNorms="true" />
> <field name="ts" type="long" indexed="true" stored="true" required="true" 
> multiValued="false" />
> {code}
> ...any code paths that are driven by isTokenized will think their may be 
> multiple terms per document when in reality there is at most one.
> we should consider redefining TrieField.isTokenized to be something like...
> {code}
> @Override
> public boolean isTokenized() {
>   return Integer.MAX_VALUE != precisionStep;
> }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to