[ 
https://issues.apache.org/jira/browse/SOLR-2976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171292#comment-13171292
 ] 

Hoss Man commented on SOLR-2976:
--------------------------------

bq. in general the precisionStep is somehow inconsistent between Solr and Lucene

it's not inconsistent, Solr's TrieField uses Integer.MAX_VALUE correctly, it 
just happily accepts config values <=0 as being equivalent to specifying 
Integer.MAX_VALUE  (the javadocs for TrieField don't even say you can specify 
"0" ... they say "Note that if you use a precisionStep of 32 for int/float and 
64 for long/double/date, then multiple terms will not be generated") .. if you 
want to add yet another symbolic constant for Integer.MAX_VALUE i'm fine with 
that, but please open a new issue -- it's totally orthogonal to what we're 
talking about here.
                
> TrieField.isTokenized returns true regardless of precisionStep
> --------------------------------------------------------------
>
>                 Key: SOLR-2976
>                 URL: https://issues.apache.org/jira/browse/SOLR-2976
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 3.5
>            Reporter: Hoss Man
>
> regardless of the precisionStep used, TrieField.isTokenized is hardcoded to 
> return true -- so even if a user has something like this in their schema...
> {code}
> <fieldType name="long" class="solr.TrieLongField" precisionStep="0" 
> omitNorms="true" />
> <field name="ts" type="long" indexed="true" stored="true" required="true" 
> multiValued="false" />
> {code}
> ...any code paths that are driven by isTokenized will think their may be 
> multiple terms per document when in reality there is at most one.
> we should consider redefining TrieField.isTokenized to be something like...
> {code}
> @Override
> public boolean isTokenized() {
>   return Integer.MAX_VALUE != precisionStep;
> }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to