[
https://issues.apache.org/jira/browse/SOLR-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180708#comment-13180708
]
Michael McCandless commented on SOLR-2438:
------------------------------------------
Hmm, working on LUCENE-995, where I had to regen QueryParser.java from
QueryParser.jj on 3.x... I noticed that when this issue was committed (well,
rev 1206258, up above), that QueryParser.java was changed yet QueryParser.jj
was not...
I'll fix that.
But even more spooky, all tests passed with that loss:
{noformat}
- protected String analyzeMultitermTerm(String field, String part, Analyzer
analyzerIn) {
- TokenStream source;
-
- if (analyzerIn == null) analyzerIn = analyzer;
-
- try {
- source = analyzerIn.tokenStream(field, new StringReader(part));
- source.reset();
- } catch (IOException e) {
- throw new RuntimeException("Unable to initialize TokenStream to analyze
multiTerm term: " + part, e);
- }
-
- CharTermAttribute termAtt = source.getAttribute(CharTermAttribute.class);
- String termRet = "";
-
- try {
- if (!source.incrementToken())
- throw new IllegalArgumentException("analyzer returned no terms for
multiTerm term: " + part);
- termRet = termAtt.toString();
- if (source.incrementToken())
- throw new IllegalArgumentException("analyzer returned too many terms
for multiTerm term: " + part);
- } catch (IOException e) {
- throw new RuntimeException("error analyzing range part: " + part, e);
- }
-
- try {
- source.end();
- source.close();
- } catch (IOException e) {
- throw new RuntimeException("Unable to end & close TokenStream after
analyzing multiTerm term: " + part, e);
- }
-
- return termRet;
- }
-
{noformat}
Do we have no test coverage for this method? Should this method be removed...?
I'm confused.
> Case Insensitive Search for Wildcard Queries
> --------------------------------------------
>
> Key: SOLR-2438
> URL: https://issues.apache.org/jira/browse/SOLR-2438
> Project: Solr
> Issue Type: Improvement
> Reporter: Peter Sturge
> Assignee: Erick Erickson
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-2438-3x.patch, SOLR-2438-3x.patch, SOLR-2438.patch,
> SOLR-2438.patch, SOLR-2438.patch, SOLR-2438.patch, SOLR-2438.patch,
> SOLR-2438.patch, SOLR-2438.patch, SOLR-2438.patch, SOLR-2438.patch,
> SOLR-2438_3x.patch
>
>
> This patch adds support to allow case-insensitive queries on wildcard
> searches for configured TextField field types.
> This patch extends the excellent work done Yonik and Michael in SOLR-219.
> The approach here is different enough (imho) to warrant a separate JIRA issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
