[
https://issues.apache.org/jira/browse/SOLR-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181061#comment-13181061
]
Erick Erickson commented on SOLR-2438:
--------------------------------------
OK, spooky is a kinder way to describe this than some I can think of. The
method in lucene...QueryParser was simply dead code, I suspect I managed to put
it there through the magic of modern IDEs. And hey, it compiles. Since this
solution is a purely Solr construct in the first place, it has no business
being in the lucene package at all.
There's an identical method in solr...TextField that is the code actually used,
so somehow I managed to put the same code in two places. Simply removing the
code from lucene...QueryParser is the right thing to do here I think, all the
tests pass when I did this manually.
And, as Yonik says, there's nothing similar in trunk.
So if I remember the patterns from lex and yacc, there's really nothing for me
to do except close this JIRA, right? Mike can freely check in the newly
generated QueryParser.java and I can remember to actually read the header that
says things about this being a generated file that shouldn't be changed....
Agree? Disagree?
Nice catch Mike!
> Case Insensitive Search for Wildcard Queries
> --------------------------------------------
>
> Key: SOLR-2438
> URL: https://issues.apache.org/jira/browse/SOLR-2438
> Project: Solr
> Issue Type: Improvement
> Reporter: Peter Sturge
> Assignee: Erick Erickson
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-2438-3x.patch, SOLR-2438-3x.patch, SOLR-2438.patch,
> SOLR-2438.patch, SOLR-2438.patch, SOLR-2438.patch, SOLR-2438.patch,
> SOLR-2438.patch, SOLR-2438.patch, SOLR-2438.patch, SOLR-2438.patch,
> SOLR-2438_3x.patch
>
>
> This patch adds support to allow case-insensitive queries on wildcard
> searches for configured TextField field types.
> This patch extends the excellent work done Yonik and Michael in SOLR-219.
> The approach here is different enough (imho) to warrant a separate JIRA issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
