[
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184444#comment-13184444
]
Mark Miller commented on SOLR-2191:
-----------------------------------
bq. personal problem that should be dealt with on a case-by-case basis.
I think it's more of a project level problem - we have to decide how we want to
handle logging and stick with it I think. It still seems the most sensible
thing is to drop this logOnce concept entirely - logging should be handled at
the fringes once the exception bubbles up.
bq. Should that variable be removed too in your opinion?
Yup - I think logged and logOnce should die die die.
> Change SolrException cstrs that take Throwable to default to
> alreadyLogged=false
> --------------------------------------------------------------------------------
>
> Key: SOLR-2191
> URL: https://issues.apache.org/jira/browse/SOLR-2191
> Project: Solr
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Erick Erickson
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-2191.patch
>
>
> Because of misuse, many exceptions are now not logged at all - can be painful
> when doing dev. I think we should flip this setting and work at removing any
> double logging - losing logging is worse (and it almost looks like we lose
> more logging than we would get in double logging) - and bad
> solrexception/logging patterns are proliferating.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
