[ https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185010#comment-13185010 ]
David Smiley commented on SOLR-2191: ------------------------------------ I agree with Mark. In code I write, I am always sure to tag on the old exception to a new one, assuming I need to throw a different exception, and I almost never log exceptions. I let the top layers handle that. Code that does otherwise has redundant logs which I find annoying. > Change SolrException cstrs that take Throwable to default to > alreadyLogged=false > -------------------------------------------------------------------------------- > > Key: SOLR-2191 > URL: https://issues.apache.org/jira/browse/SOLR-2191 > Project: Solr > Issue Type: Bug > Reporter: Mark Miller > Assignee: Erick Erickson > Fix For: 3.6, 4.0 > > Attachments: SOLR-2191.patch > > > Because of misuse, many exceptions are now not logged at all - can be painful > when doing dev. I think we should flip this setting and work at removing any > double logging - losing logging is worse (and it almost looks like we lose > more logging than we would get in double logging) - and bad > solrexception/logging patterns are proliferating. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org